You're right about where I was when I went into Boot Camp. Your pull ups could use a bit of work, but then nearly everyone's could.
I dont have any questions to add to your list as of yet, but I do have some ideas for pre-recruiter visit research.
Do some real hard thinking and soul searching on what it is you really want from your service time.
Not everyone can be, nor should everyone want to be, infantry. But, there's few things more miserable than someone who, deep in their hearts, wanted to be a grunt but then opted for something else or went in open contract thinking they'd get infantry automatically.
Once you get your head wrapped around what sort of job you want to learn, read read read read up on all the MOS's that apply to that job field, and read read read more on all the other MOS's you can find info on. You never know when you'll run into that one job description/schooling package that just trips your ticket and tickles your fancy. There's a crap load to pick from so read as much as you can on as many as you can.
Also, for the youngsters, do some deep thought on the concept that the US Military exists to serve the defense needs of the US of A and not to fulfill the ego needs of select young soldiers. If you wanted sniper, ranger, SEAL, super duper uber elite whatever, and don't get it, welcome to the real world. Don't take it personally and dont let it ruin you're time in service by breeding a bull**it attitude over it.
When considering an MOS, put some thought into after your service. Some set you up much better for a head start in the civilian world than others but all military jobs will gain you some.
Ok, one question series would be, what's available now in (give your desired MOS spread here), what's available within x amount of time (x = time you feel you are willing to wait) and what requirements must I meet prior to signing for the MOS picked (assuming you can set your mind on one).
Get it in writing. That's probably the best advice going.
Equivocation is the first step along the road to capitulation.